[d16-9] [msbuild] Fix codesign StampPath. Fix #10445 - #10463
Merged
Conversation
Using `Path.Combine` with a full qualified path for the 2nd argument will return that 2nd argument (ignoring the first one). That meant the `StampPath` was pointing to the actual files that were just signed - overwriting them with a 0-length data (empty). The solution is to make the 2nd argument relative, starting after `.app/` so `Path.Combine` works as expected (being relative) while allowing signing multiple files that have the same name (in different directories). ref: #10445
vs-mobiletools-engineering-service2
requested review from
emaf and
rolfbjarne
as code owners
January 19, 2021 16:10
rolfbjarne
approved these changes
Jan 19, 2021
dalexsoto
approved these changes
Jan 19, 2021
mandel-macaque
approved these changes
Jan 19, 2021
Collaborator
Author
❌ Tests failed on Build ❌Tests failed on Build. Test results3 tests failed, 38 tests passed.Failed tests
Pipeline on Agent XAMBOT-1094' |
emaf
approved these changes
Jan 20, 2021
stephen-hawley
approved these changes
Jan 20, 2021
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
Path.Combinewith a full qualified path for the 2nd argument willreturn that 2nd argument (ignoring the first one).
That meant the
StampPathwas pointing to the actual files that werejust signed - overwriting them with a 0-length data (empty).
The solution is to make the 2nd argument relative, starting after
.app/soPath.Combineworks as expected (being relative) whileallowing signing multiple files that have the same name (in different
directories).
ref: #10445
Backport of #10459